Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimeo: listen for bufferring events and handle with matching callbacks #975

Merged

Conversation

metamorfoso
Copy link
Contributor

Hey there, thanks for the nice player, it's been great for us.

Just wanted to a add a small feature for our use case: being able to use the onBuffer and onBufferEnd callbacks with the vimeo player.

A very basic change, following the Vimeo spec:
https://developer.vimeo.com/player/sdk/reference#bufferstart
https://developer.vimeo.com/player/sdk/reference#bufferend

@cookpete cookpete merged commit 0aa2dee into cookpete:master Jul 23, 2020
@cookpete
Copy link
Owner

Nice one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants